Skip to content

Add Luno API support & ZAR to LBC labels

T Dev. D requested to merge github/fork/FedoraTipper/develop into develop

Created by: FedoraTipper

Good day,

I've worked up a solution to add luno's API to the wallet, which extends current supported currency to include ZAR, NGN, MYR and IDR. I've also included a quick edit to LBC workings to add ZAR. Which can also be added for the rest.

I've tested my code for luno, which works with all the currencies given. If new currency were to be added to luno's json, a simple string add to currencyLabelsLuno variables will get it working on the app as well.

Side notes:

I'm not too familiar with json, I've tried multiple ways to get it working with luno. Due to luno's structure of the JSON objects, it seems near impossible to get it going. Without wasting more time, I've rather went with a regex split to source out the info.

Example of how the regex works: https://i.imgur.com/pngrKGO.png

There should be a quicker and easier way to do this, for now this all I could think of.

Merge request reports