samourai-wallet-android issueshttps://code.samourai.io/wallet/samourai-wallet-android/-/issues2021-10-13T07:46:41Zhttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/443Security issue: Bypass PIN login attempts2021-10-13T07:46:41Zㅤ ㅤSecurity issue: Bypass PIN login attemptsHello, the current login with PIN mechanism and attempts counter (failures) can be bypassed leading to brute-force attacks.
If a user fails the login 2 times and restart the Samourai application, the counter will reset. Also, the PIN is...Hello, the current login with PIN mechanism and attempts counter (failures) can be bypassed leading to brute-force attacks.
If a user fails the login 2 times and restart the Samourai application, the counter will reset. Also, the PIN is not complex enough to protect the wallet by encryption.
The current logic stores the number of attempts during runtime:
https://code.samourai.io/wallet/samourai-wallet-android/-/blob/develop/app/src/main/java/com/samourai/wallet/PinEntryActivity.java#L302
```
try {
HD_Wallet hdw = PayloadUtil.getInstance(PinEntryActivity.this).restoreWalletfromJSON(new CharSequenceX(AccessFactory.getInstance(PinEntryActivity.this).getGUID() + pin));
runOnUiThread(() -> {
progressBar.setVisibility(View.INVISIBLE);
});
if (hdw == null) {
runOnUiThread(() -> {
failures++;
Toast.makeText(PinEntryActivity.this, PinEntryActivity.this.getText(R.string.login_error)
+ ":" + failures + "/3", Toast.LENGTH_SHORT).show();
if (failures == 3) {
failures = 0;
doBackupRestore();
} else {
Intent intent = new Intent(PinEntryActivity.this, PinEntryActivity.class);
// intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK | Intent.FLAG_ACTIVITY_NEW_TASK);
startActivity(intent);
finish();
}
});
}
```https://code.samourai.io/wallet/samourai-wallet-android/-/issues/442Allow Samourai to NOT be the default app for opening a USB2021-06-25T05:34:38ZMax TannahillAllow Samourai to NOT be the default app for opening a USBFor users that use USB on their phone regularly and not an OpenDime device, could there be a setting for not making new media open with Samourai constantly?![IMG_20210625_133027](/uploads/a07cb8d43fafd74a5bb7859668b6e92a/IMG_20210625_133...For users that use USB on their phone regularly and not an OpenDime device, could there be a setting for not making new media open with Samourai constantly?![IMG_20210625_133027](/uploads/a07cb8d43fafd74a5bb7859668b6e92a/IMG_20210625_133027.jpg)https://code.samourai.io/wallet/samourai-wallet-android/-/issues/413Chosen value unit (sat) does not remain default unit when switching between w...2020-07-20T01:02:51ZtadogenChosen value unit (sat) does not remain default unit when switching between wallets.Whenever i set my unit to "sat", and switch from my premix wallet to my post mix wallet or back, the value unit goes back to the default bitcoin unit, btc. Is there anyway that the chosen "sat" unit can stay permanent, it makes calculati...Whenever i set my unit to "sat", and switch from my premix wallet to my post mix wallet or back, the value unit goes back to the default bitcoin unit, btc. Is there anyway that the chosen "sat" unit can stay permanent, it makes calculations easier?
![Screen_Recording_20200718-213642_Samourai_1](/uploads/4ff73e650b372e4d390d192af47f3360/Screen_Recording_20200718-213642_Samourai_1.mp4)https://code.samourai.io/wallet/samourai-wallet-android/-/issues/445Improvement for Networking View and Dojo state indication2021-10-12T14:09:28ZChuck NorrisonImprovement for Networking View and Dojo state indication### Current behaviour
The current Networking view will display Data Connection and Tor Routing. Dojo will also be visible if enabled. The state of function is shown with a green indicator.
Red gets shown if Dojo Full Node is Disabled.
...### Current behaviour
The current Networking view will display Data Connection and Tor Routing. Dojo will also be visible if enabled. The state of function is shown with a green indicator.
Red gets shown if Dojo Full Node is Disabled.
![image](/uploads/bda857d5df4aa556f90420bf5fbe8953/image.png)
### Improvement
If a Dojo Full Node is Enabled but shutdown and not available at the moment, the Balance changes to 0. The Networking view is still green for the Dojo Full Node. In this case the indicator could switch orange to visualize a "Wait for Connection" or more unexpected states to come.Wallet Guywg@samourai.ioWallet Guywg@samourai.iohttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/429[Feature Request] Custom fee boost2021-02-25T19:54:11Zben[Feature Request] Custom fee boostI would like to be able to customize the transaction fee increase for RBF transactions. With how high the fees are right now, the one option for a fee boost that samourai wallet gives is *way* to high. I want to increase the fees just en...I would like to be able to customize the transaction fee increase for RBF transactions. With how high the fees are right now, the one option for a fee boost that samourai wallet gives is *way* to high. I want to increase the fees just enough that the transaction confirms over the weekend.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/424Error locallization pt-BR2021-02-03T06:43:05ZCleber Matheus A. SilvaError locallization pt-BRThe application when running on a device in Brazilian Portuguese is erroneously translated as Portuguese of Portugal, but when changing the language to Breton (Brittany, France) the application is translated into Brazilian Portuguese.![d...The application when running on a device in Brazilian Portuguese is erroneously translated as Portuguese of Portugal, but when changing the language to Breton (Brittany, France) the application is translated into Brazilian Portuguese.![device-2021-01-03-185215_2](/uploads/9a02eaa88fb89972bb81c64934fd8f13/device-2021-01-03-185215_2.mp4)SarathSarathhttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/418UX: set Post-Mix as default wallet2020-10-31T00:00:23Zr4v3r23UX: set Post-Mix as default walletoption to set Whirlpool Wallet (post-mix) as default spending wallet that opens on start up.
Also add these to Whirlpool Wallet FAB:
- Whirlpool button: to manage mixes
- Receive button: auto-mixes based on chosen pool size & low/med/h...option to set Whirlpool Wallet (post-mix) as default spending wallet that opens on start up.
Also add these to Whirlpool Wallet FAB:
- Whirlpool button: to manage mixes
- Receive button: auto-mixes based on chosen pool size & low/med/high fee rate
- PayNym button: cause why nothttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/417Visibly show status of Dojo connection2020-10-07T13:50:21ZOr WeinbergerVisibly show status of Dojo connectionWhen a wallet is paired with a Dojo and the Dojo goes offline, the user does not get any notification or visibility to the status.
Even manually refreshing the wallet does not show any issues and the 'Connections' screen shows the Dojo ...When a wallet is paired with a Dojo and the Dojo goes offline, the user does not get any notification or visibility to the status.
Even manually refreshing the wallet does not show any issues and the 'Connections' screen shows the Dojo Full Node as enabled with a green dot next to it.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/415App crash when pressing "show QR code" after "cannot compose #cahoots" message2020-11-16T09:33:00ZDamm KewlApp crash when pressing "show QR code" after "cannot compose #cahoots" messageSomebody tried to cahoots with me, my available funds amount couldn't match his as I didn't have enough. I didn't know this beforehand, so I tried to use his cahoots payload.
Both the scenario's of "paste cahoots payload" and scanning t...Somebody tried to cahoots with me, my available funds amount couldn't match his as I didn't have enough. I didn't know this beforehand, so I tried to use his cahoots payload.
Both the scenario's of "paste cahoots payload" and scanning the QR code both played out the same on the following:
- Went to postmix wallet screen
- Have 1 UTXO available (other ones set to do-not-spend)
- Pasted the payload / Scanned the QR code
- Screen switches to the cahoots screen
- got the "cannot compose #cahoots" temporary message at the bottom
- I press "show QR code"
- the app crashes
- thereafter the app instantly reloads and asks for pin number
The reason for me trying to "show QR code" despite the "cannot compose #cahoots" message was that I didn't see the error message the first time. I think it was because of how I held my phone that it wasn't in my field of view for the short time it was on the screen.
The type of cahoots was specifically a StonewallX2 initiated by the other person.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/411[Feature Request] Offline Sign2020-05-14T14:01:00ZT Dev. D[Feature Request] Offline Sign*Created by: andretrevisani*
I use Samourai Wallet in offline mode. I can receive BTC using Sentinel, but I cannot spend this newly received UTXO, since the offline Samourai Wallet does not have any info of that. The only way I found ou...*Created by: andretrevisani*
I use Samourai Wallet in offline mode. I can receive BTC using Sentinel, but I cannot spend this newly received UTXO, since the offline Samourai Wallet does not have any info of that. The only way I found out is to bring it online to resync, then offline again (kind of beats the purpose of it).
It would be great if I could create an unsigned transaction on the Sentinel wallet (since it has all the info needed), and send it to be signed on the offline Samourai (using QR-code).
It would actually make an offline Samourai Wallet a kind of "hardware wallet", isolated by airgap.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/407Message signing includes different address as part of its output2021-06-03T17:28:52ZT Dev. DMessage signing includes different address as part of its output*Created by: kargakis*
I have sent some BTC to a Samourai wallet (bech32 address) and when I try to sign that address, the generated signature seems to be for a totally different address (legacy p2pkh). Not sure if it is worth to post ...*Created by: kargakis*
I have sent some BTC to a Samourai wallet (bech32 address) and when I try to sign that address, the generated signature seems to be for a totally different address (legacy p2pkh). Not sure if it is worth to post the original address and the generated signature but if you think so I can post them.
FWIW the seed for the wallet has been manually imported (I had no funds at start, then I sent some BTC to an address generated by Samourai).https://code.samourai.io/wallet/samourai-wallet-android/-/issues/355The fee slider makes it very hard to fine tune fees.2020-02-23T04:41:37ZT Dev. DThe fee slider makes it very hard to fine tune fees.*Created by: Relaxo143*
Fee estimations are often very wrong (even with dojo). If the urgent fee is 100 sats/byte and I want to set it to 2, it's almost impossible. the slightest move of the slider goes from 1 to 10 sats/byte. It would ...*Created by: Relaxo143*
Fee estimations are often very wrong (even with dojo). If the urgent fee is 100 sats/byte and I want to set it to 2, it's almost impossible. the slightest move of the slider goes from 1 to 10 sats/byte. It would be nice to be able to type the value manually.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/465Avoid generating dust change after the Tx02024-01-09T20:51:55ZArkad .Avoid generating dust change after the Tx0In certain scenarios when initiating a Tx0, the toxic change (unmixed change) can have a very low value. The issue is that transferring that UTXO later can be inefficient/costly. Sparrow wallet can detect if the toxic change generated in...In certain scenarios when initiating a Tx0, the toxic change (unmixed change) can have a very low value. The issue is that transferring that UTXO later can be inefficient/costly. Sparrow wallet can detect if the toxic change generated in the Tx0 is dust (≤5,000 sats, the amount can be adjusted based on the state of mempool fees) and suggest to the user to spend that amount on the mining fee for the Tx0. Sparrow already does this with simple/efficient transactions.
The benefits would be a reduced probability of dust in the Bad bank, avoidance of consolidations of low-value toxic changes, and the Tx0 would eliminate an inefficient output.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/464[Feature Request] Having the ability to choose the direction of toxic change2024-01-09T20:56:40ZArkad .[Feature Request] Having the ability to choose the direction of toxic changeThe toxic UTXO is the unmixed change derived from the Whirlpool Tx0. This UTXO must be treated individually for privacy reasons. After the Tx0, this change goes to the Bad Bank account. Following that Tx0, the user can sweep it out of th...The toxic UTXO is the unmixed change derived from the Whirlpool Tx0. This UTXO must be treated individually for privacy reasons. After the Tx0, this change goes to the Bad Bank account. Following that Tx0, the user can sweep it out of the wallet with an additional transaction.
Would it be possible to choose the destination address for that toxic change in the same Tx0 without having to make an additional transaction? This would be a gain as we could save on fees, especially in these times of transaction accumulation in the mempool.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/463App reopens itself2023-11-16T18:44:39ZSantochi NacamochoApp reopens itselfHi,
After I exit the app, it reopens itself again. I have to restart the phone to avoid it.
I have Android 8.1.0 and Samourai 0.99.98i.Hi,
After I exit the app, it reopens itself again. I have to restart the phone to avoid it.
I have Android 8.1.0 and Samourai 0.99.98i.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/460Boosting fee fails with a message I don't understand2023-06-21T14:06:24ZJoseBoosting fee fails with a message I don't understandI did a transaction and then tried to boost on version 0.99.98g. The boost failed with the attached message which I don't understand.
I would have expected the boost would have worked. If the boost failed then I would expect to have got...I did a transaction and then tried to boost on version 0.99.98g. The boost failed with the attached message which I don't understand.
I would have expected the boost would have worked. If the boost failed then I would expect to have gotten an error I could understand and clear instructions on what I should do.
![signal-2023-06-21-085930_002](/uploads/fc9040a1b218b1f4537a563405138c9f/signal-2023-06-21-085930_002.jpeg)https://code.samourai.io/wallet/samourai-wallet-android/-/issues/454Review transaction change_is_dust2022-11-27T17:01:44ZSantochi NacamochoReview transaction change_is_dustHello,
I want to spend specific UTXO of 100k sats to send 99400. I select the unspent UTXO, introduce the amount to be sent. The slide to configured the fee is not shown yet. When I click review transaction I get the change_is_dust messa...Hello,
I want to spend specific UTXO of 100k sats to send 99400. I select the unspent UTXO, introduce the amount to be sent. The slide to configured the fee is not shown yet. When I click review transaction I get the change_is_dust message, I want to add all the change to the fee, but I can't finish the transaction.
Also the Spanish translation is misleading. The English message says:
The change from this transaction is a dust amount. Try again and either modify the spend amount or spend the entire balance
The Spanish translation says:
The change from this transaction is a dust amount and will be added to the miner fee
When I see that message, I think that it is ok and I want to complete the transaction, but nothing happens.
The Spanish translation should be changed to match the English message:
El cambio de esta transacción es una cantidad ínfima. Inténtelo de nuevo y modifique el importe del gasto o gaste todo el saldo.
However, I will be in the same situation, because I can't change anything, I can't change the spend amount, I want to use that UTXO and I can't change the fee.
If I reduce the amount to 99300 I don't see the change_is_dust message and the send dialog is shown. I can configure the fee, but the mempool is empty, the max allowed fee is 1 sat/b and the change_is_dust message is shown again when I press the send button.
The dialog that shows the change_is_dust message could used a variation of the Spanish translation "The change from this transaction is a dust amount and will be added to the miner fee, ok?" and show ok and cancel buttons. If I press OK, the dust is added to the fee and everybody happy.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/453A new type of Whirlpool Spend Privacy Tool2022-10-09T13:09:18ZUn ExA new type of Whirlpool Spend Privacy Tool
I'm a happy and long time user of the samourai wallet and recently I got an idea of a tool to spend from whirlpool to another Samourai wallet user. I called it Passepartout (from the french goes everywhere).
**The idea:**
What passepa...
I'm a happy and long time user of the samourai wallet and recently I got an idea of a tool to spend from whirlpool to another Samourai wallet user. I called it Passepartout (from the french goes everywhere).
**The idea:**
What passepartout transactions would do is to enable to spend from your mixed whirlpool balance without going out of whirlpool enabling you an the receiver to benefit from the endless remixes. The only downside would be that you need to wait for potentially a few days to get a free remix.
This would also restrict the amount to one that correspond to one of the whirlpool pools eg: 0.01 BTC.
**Technically that would work in two stage:**
The recipient generate a QR code with a fresh address from its whirlpool derivation path.
Dojo flags this address to NOT be used for its own future remix.
The sender scan the QR code, confirm to send an amount. As soon as one of its UTXO is selected for remix the sender sign and send it to the recipient address instead of their own.
Both the recipient and sender can continue remixing endlessly, the service would be free for both the sender and recipient.
Advantages:
- Allow users send bitcoin within a standard whirlpool transaction
- Increase the uncertainty around the flow of funds inside whirlpool.
- If a user send 1 btc inside whirlpool they might never withdraw 1 btc since some of it might have been used to pay for services inside the whirlpool.
- Similar if a user withdraw 1 btc they might never have sent anything to whirlpool.
- Increase the quantity of bitcoin in the pool to provide more liquidity.
- Allow to send Bitcoin at effectively 0 cost
Cons:
- This is potentially slow, you might need to wait hours if not days to get a remix.
- Both users must use samourai and potentially a dojo node to be able to craft this special remix transaction. (Although this might be seen as a plus since more people would use samourai and install dojo).
- This is limited to a round amount from one of the pool denomination.
- This might introduce address reuse if not done carefully. Every address that the receiver presents must be truly unique and survive a wallet restore.
- Checks from both the recipient and sender must be done before hand to avoid any reuse especially inside whirlpool.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/452PayNym page showing black bars2022-08-17T12:40:41Z+rapidlab309samourai@rapidlab309.mePayNym page showing black barsUsing Pixel 5a with CalyxOS, Samourai was downloaded from F-Droid (last version: 0.99.98e)
Whenever entering the PayNym screen, I'm having black bars around the following/followers part; I think it's because my phone settings set to be ...Using Pixel 5a with CalyxOS, Samourai was downloaded from F-Droid (last version: 0.99.98e)
Whenever entering the PayNym screen, I'm having black bars around the following/followers part; I think it's because my phone settings set to be on the minimal size.
![photo_2022-08-17_15-38-33](/uploads/5a974bf3828722745d9037ecb5afc5c2/photo_2022-08-17_15-38-33.jpg)https://code.samourai.io/wallet/samourai-wallet-android/-/issues/451F-Droid repo is not available2022-08-17T14:53:54ZxuhccF-Droid repo is not availableRepository is not available: https://repo.samourai.io/fdroid/repo
This repo address is published at https://samouraiwallet.com/download/fdroid pageRepository is not available: https://repo.samourai.io/fdroid/repo
This repo address is published at https://samouraiwallet.com/download/fdroid page