samourai-wallet-android issueshttps://code.samourai.io/wallet/samourai-wallet-android/-/issues2020-10-07T13:42:14Zhttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/416Secure erase wallet feature does not work properly2020-10-07T13:42:14ZOr WeinbergerSecure erase wallet feature does not work properly**Version**: 9.99.95t
**OS**: Android 10
**Hardware**: OnePlus 7T
When trying to securely erase an existing wallet, I get the 'Securely wiping wallet. Please wait.' message and the application just hangs. Trying to kill the app and re...**Version**: 9.99.95t
**OS**: Android 10
**Hardware**: OnePlus 7T
When trying to securely erase an existing wallet, I get the 'Securely wiping wallet. Please wait.' message and the application just hangs. Trying to kill the app and re initiating the process also hangs.
The only way I managed to bypass this issue is by completely deleting the app from my phone and reinstalling it.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/413Chosen value unit (sat) does not remain default unit when switching between w...2020-07-20T01:02:51ZtadogenChosen value unit (sat) does not remain default unit when switching between wallets.Whenever i set my unit to "sat", and switch from my premix wallet to my post mix wallet or back, the value unit goes back to the default bitcoin unit, btc. Is there anyway that the chosen "sat" unit can stay permanent, it makes calculati...Whenever i set my unit to "sat", and switch from my premix wallet to my post mix wallet or back, the value unit goes back to the default bitcoin unit, btc. Is there anyway that the chosen "sat" unit can stay permanent, it makes calculations easier?
![Screen_Recording_20200718-213642_Samourai_1](/uploads/4ff73e650b372e4d390d192af47f3360/Screen_Recording_20200718-213642_Samourai_1.mp4)https://code.samourai.io/wallet/samourai-wallet-android/-/issues/412[Feature Request] Turn off wallet2020-05-27T04:44:36ZTransisto[Feature Request] Turn off walletHow to disable whirlpool and Samourai wallet background process with the notification icon?How to disable whirlpool and Samourai wallet background process with the notification icon?https://code.samourai.io/wallet/samourai-wallet-android/-/issues/411[Feature Request] Offline Sign2020-05-14T14:01:00ZT Dev. D[Feature Request] Offline Sign*Created by: andretrevisani*
I use Samourai Wallet in offline mode. I can receive BTC using Sentinel, but I cannot spend this newly received UTXO, since the offline Samourai Wallet does not have any info of that. The only way I found ou...*Created by: andretrevisani*
I use Samourai Wallet in offline mode. I can receive BTC using Sentinel, but I cannot spend this newly received UTXO, since the offline Samourai Wallet does not have any info of that. The only way I found out is to bring it online to resync, then offline again (kind of beats the purpose of it).
It would be great if I could create an unsigned transaction on the Sentinel wallet (since it has all the info needed), and send it to be signed on the offline Samourai (using QR-code).
It would actually make an offline Samourai Wallet a kind of "hardware wallet", isolated by airgap.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/373App crash on QR code scanner open if previously denied camera permission2020-05-03T03:23:11ZT Dev. DApp crash on QR code scanner open if previously denied camera permission*Created by: alekskuzmin*
### App version
0.99.88
### Steps to reproduce
- When asked for camera permission, deny
- When on home screen, try to open QR code scanner*Created by: alekskuzmin*
### App version
0.99.88
### Steps to reproduce
- When asked for camera permission, deny
- When on home screen, try to open QR code scannerhttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/343[Feature Request] Implement manual address incrementation2020-04-17T22:29:48ZT Dev. D[Feature Request] Implement manual address incrementation*Created by: Technifocal*
Akin to `whirlpool-client-cli`'s `deposit`'s `increment=true` argument documented [here](https://github.com/Samourai-Wallet/whirlpool-client-cli/blob/641aed289af0d16092bd994fac288894162b3f4f/README-API.md#depos...*Created by: Technifocal*
Akin to `whirlpool-client-cli`'s `deposit`'s `increment=true` argument documented [here](https://github.com/Samourai-Wallet/whirlpool-client-cli/blob/641aed289af0d16092bd994fac288894162b3f4f/README-API.md#deposit-get-restwalletdepositincrementfalse), allow a user to generate an address and mark it as used (or simply allow a user to mark an already generated address as used).
This would allow users who have shared their address to mark it as such and prevent it from being shown again by the app when they click "receive".
This could:
* Prevent address reuse if receiving multiple transactions at once
* Prevent an attacker who has received an address from a Samourai user from not sending any funds to it and monitoring the next transaction it receiveshttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/405Problem connecting via Tor on Samsumg XCover 4C2020-04-17T18:37:02ZT Dev. DProblem connecting via Tor on Samsumg XCover 4C*Created by: pantadeusz*
Configuration that works:
* (short) Motorola, android 7.0 - all works well (not tested with Dojo)
* Samourai fro APK: 0.99.91 SHA:6be628ad....
Configuration with problems
* Samsung XCover 4s
* SM-G39...*Created by: pantadeusz*
Configuration that works:
* (short) Motorola, android 7.0 - all works well (not tested with Dojo)
* Samourai fro APK: 0.99.91 SHA:6be628ad....
Configuration with problems
* Samsung XCover 4s
* SM-G398FN
* Android 9, G398FNXXS4ATB5, ver PPR1.180610.011.G398FNXXS4ATB55, Knox 3.3
* only wifi/bluetooth connection (tested with multiple access points)
* Samourai fro APK: 0.99.91 SHA:6be628ad....
* dojo + explorer (can send as PM) (Dojo v1.5.0)
## The problem
On my Motorola, everything works fine, but I didn't test with Dojo (I don't want to reset my config until I have working online wallet on second phone). Tor and plain net works great.
On Samsung there is a problem:
* On plainnet it imports wallet without problems and shows balance correctly
* On Tor it randomly shows correct balance or 0
* Via Dojo it always shows 0 balance
The Dojo seems to be working fine, the TorBrowser on Samsung works good and allows to use web interface on Dojo. The Tor on Samourai however does not want to cooperate with my Dojo.
The logs from API (when I refersh balance on my wallet) starts to appear as follows:
```raw
[20200409 11:12:12.010 026 MiB] POST /xpub
[20200409 11:12:14.017 026 MiB] POST /unspent
[20200409 11:12:15.581 026 MiB] POST /multiaddr
[20200409 11:12:17.359 026 MiB] POST /unspent
[20200409 11:12:19.524 026 MiB] GET /fees?at=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJTYW1vdXJhaSBXYWxsZXQgYmFja2VuZCIsInR5cGUiOiJhY2Nlc3MtdG9rZW4iLCJwcmYiOiJhcGkiLCJpYXQiOjE1ODY0Mjk3MDgsImV4cCI6MTU4NjQzMDYwOH0.BxMp0Zpq9TGANkkGFtjrfepKFpicDnvRGJcSq5umEBs
[20200409 11:12:21.290 026 MiB] POST /multiaddr
[20200409 11:12:22.861 026 MiB] POST /unspent
[20200409 11:12:24.404 026 MiB] POST /multiaddr
[20200409 11:12:26.185 026 MiB] POST /unspent
[20200409 11:12:27.858 026 MiB] POST /multiaddr
[20200409 11:12:30.188 025 MiB] POST /unspent
```
The Get request gives only the following information
```json
{"status":"ok"}
```https://code.samourai.io/wallet/samourai-wallet-android/-/issues/409Secure wallet delete takes forever if wallet if not synced2020-04-14T21:14:02ZT Dev. DSecure wallet delete takes forever if wallet if not synced*Created by: dimaatmelodromru*
If trying to initiate Secure wallet delete while blue line is still flashing the spinner will spin forever*Created by: dimaatmelodromru*
If trying to initiate Secure wallet delete while blue line is still flashing the spinner will spin foreverhttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/408For more security spongycastle -> bouncycastle2020-04-14T11:52:25ZT Dev. DFor more security spongycastle -> bouncycastle*Created by: Neustradamus*
For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?
- https://www.bouncycastle.org/
- https://www.bouncycastle.org/releasenotes.html
- http://www.bouncycastle.org...*Created by: Neustradamus*
For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?
- https://www.bouncycastle.org/
- https://www.bouncycastle.org/releasenotes.html
- http://www.bouncycastle.org/latest_releases.html
- https://www.cvedetails.com/vulnerability-list/vendor_id-7637/Bouncycastle.htmlhttps://code.samourai.io/wallet/samourai-wallet-android/-/issues/391Crashing when setting trusted node2020-04-07T02:12:38ZT Dev. DCrashing when setting trusted node*Created by: Moller40*
Does not matter if it's a valid node or not. Can trigger the crash by setting this:
IP address: 111.111.111.111
Port: 8332
rpc user name: name
rpc user password: pass
```
02-19 11:32:12.772 18309 18922 E...*Created by: Moller40*
Does not matter if it's a valid node or not. Can trigger the crash by setting this:
IP address: 111.111.111.111
Port: 8332
rpc user name: name
rpc user password: pass
```
02-19 11:32:12.772 18309 18922 E AndroidRuntime: FATAL EXCEPTION: Thread-9
02-19 11:32:12.772 18309 18922 E AndroidRuntime: Process: com.samourai.wallet, PID: 18309
02-19 11:32:12.772 18309 18922 E AndroidRuntime: java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/http/impl/client/DefaultHttpClient;
02-19 11:32:12.772 18309 18922 E AndroidRuntime: at com.samourai.wallet.JSONRPC.JSONRPC.doRPC(JSONRPC.java:255)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: at com.samourai.wallet.JSONRPC.JSONRPC.getNetworkInfoAsString(JSONRPC.java:220)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: at com.samourai.wallet.SettingsActivity2$42$1.run(SettingsActivity2.java:1178)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: at java.lang.Thread.run(Thread.java:919)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: org.apache.http.impl.client.DefaultHttpClient
02-19 11:32:12.772 18309 18922 E AndroidRuntime: ... 4 more
02-19 11:32:12.775 1749 9193 I am_crash: [18309,0,com.samourai.wallet,950550084,java.lang.ClassNotFoundException,org.apache.http.impl.client.DefaultHttpClient,JSONRPC.java,255]
```
Using Android 10. Maybe that triggers this problem?
Samourai version: 0.99.88https://code.samourai.io/wallet/samourai-wallet-android/-/issues/404SLIP-39 compatibility2020-04-05T13:47:33ZT Dev. DSLIP-39 compatibility*Created by: brokker*
I can work on implementing [SLIP-39](https://github.com/satoshilabs/slips/blob/master/slip-0039.md) in 2 steps if you think it's a good idea that has a chance of being merged @SamouraiDev .
The work can be split...*Created by: brokker*
I can work on implementing [SLIP-39](https://github.com/satoshilabs/slips/blob/master/slip-0039.md) in 2 steps if you think it's a good idea that has a chance of being merged @SamouraiDev .
The work can be split in 2 steps:
Step 1: Recovery of existing SLIP-39 shares in SW in recovery mode
Step 2: Backup to SLIP-39 shares during SW setup
Please let me know.
Thanks.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/400Incorrect Address Reflected in the Address Reuse Alert2020-03-10T02:50:31ZT Dev. DIncorrect Address Reflected in the Address Reuse Alert*Created by: dav1dpgit*
In the phone SW application, bitcoin addresses entered or updated on the second screen of the send process are not used for warnings and alerts; worried that it might not be updating the actual destination addres...*Created by: dav1dpgit*
In the phone SW application, bitcoin addresses entered or updated on the second screen of the send process are not used for warnings and alerts; worried that it might not be updating the actual destination address, either, but did not confirm the latter topic.
The following steps produces an incorrect set of information error:
1) Screen 1: Send bitcoin from the post-mix whirlpool. Select the box-brackets at the top of the screen to scan a QR code for an address where the address scanned is a reuse of an previously sent bitcoin address from the SW wallet.
2) Set the amount sent and continue to Screen 2 for fee amount and verification.
3) Screen 2: Set fee amount and initiate send; a popup box will alert that the address is a reused address and allow user to change to another address. Select this option to change address.
4) **On Screen 2**, select the box-brackets at the top of the screen to scan a new address QR code that has not been previously used. The newly scanned unused address fills the destination address information in Screen 2.
5) Initiate send again. The popup alert box returns again stating the address is a reused address and reflects the **initial, first-input** address.
The way I have eliminated this error is to return to Screen 1 and re-start the information input from the beginning.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/395Privacy Addons not showing on specific UTXO Spend screen2020-02-28T15:38:38ZT Dev. DPrivacy Addons not showing on specific UTXO Spend screen*Created by: bitcoinheiro*
The "Privacy Addons" features are not being shown (cut out of screen apparently)
when sending TX with specific UTXO selected using the new Spend from UTXO feature.
(Manage UTXOs>Specific UTXO>Advanced>Spen...*Created by: bitcoinheiro*
The "Privacy Addons" features are not being shown (cut out of screen apparently)
when sending TX with specific UTXO selected using the new Spend from UTXO feature.
(Manage UTXOs>Specific UTXO>Advanced>Spend)
Happens to regular txs and Post-mix Whirlpool txs
See screenshots for details.
![01](https://user-images.githubusercontent.com/50273260/75562121-be9c0180-5a50-11ea-9541-d6051e5a52c9.jpeg)
![02](https://user-images.githubusercontent.com/50273260/75562114-bcd23e00-5a50-11ea-8411-1db117a6d028.jpeg)
![03](https://user-images.githubusercontent.com/50273260/75562117-bd6ad480-5a50-11ea-8c58-1138423895bf.jpeg)
![04](https://user-images.githubusercontent.com/50273260/75562119-be036b00-5a50-11ea-8a80-452403c8b663.jpeg)
https://code.samourai.io/wallet/samourai-wallet-android/-/issues/355The fee slider makes it very hard to fine tune fees.2020-02-23T04:41:37ZT Dev. DThe fee slider makes it very hard to fine tune fees.*Created by: Relaxo143*
Fee estimations are often very wrong (even with dojo). If the urgent fee is 100 sats/byte and I want to set it to 2, it's almost impossible. the slightest move of the slider goes from 1 to 10 sats/byte. It would ...*Created by: Relaxo143*
Fee estimations are often very wrong (even with dojo). If the urgent fee is 100 sats/byte and I want to set it to 2, it's almost impossible. the slightest move of the slider goes from 1 to 10 sats/byte. It would be nice to be able to type the value manually.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/181Please Support Multiple Wallets2020-02-19T10:04:52ZT Dev. DPlease Support Multiple Wallets*Created by: kelna*
Please add support for multiple wallets as Mycelium and others do. I would like to use Samourai for multiple, unrelated projects and I need separate wallets for that.*Created by: kelna*
Please add support for multiple wallets as Mycelium and others do. I would like to use Samourai for multiple, unrelated projects and I need separate wallets for that.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/390Pop toast for Ricochet fee2020-02-16T20:29:35Zheady_wookPop toast for Ricochet feeWhile fees for premium addons are publicly available around the internet (e.g., support.samourai.io/section/11-premium-transaction-fees), fees are no where to be found in the Samourai android app. Compared to experienced users (who may a...While fees for premium addons are publicly available around the internet (e.g., support.samourai.io/section/11-premium-transaction-fees), fees are no where to be found in the Samourai android app. Compared to experienced users (who may already be aware of the fee), novice users are left responsible to: Do the math (i.e., transaction total - send amount = ricochet fee) or leave the app for a Google fee search when reviewing a transaction. The explicit lack of fee information makes it easy for a user to approve a transaction while being unaware there was an added fee. This may result in a negative user experience.
This issue can be resolved by popping a toast message when the privacy addon Ricochet is selected. A benefit includes added transparency regarding fees for novice users. A risk is that experienced users might find it redundant. The fix can be applied by adding the following lines of code to the respective files:
- File: strings.xml
- Code: `<string name="ricochet_fee">Ricochet Fee: 0.002 BTC</string>`
- Image:
- ![image](https://user-images.githubusercontent.com/38931215/74611508-76c0c600-50b1-11ea-8a82-940a74a0ffb5.png)
and then,
- File: SendActivity.java
- Code: `Toast.makeText(getApplicationContext(),R.string.ricochet_fee,Toast.LENGTH_SHORT).show();`
- Image:
- ![image](https://user-images.githubusercontent.com/38931215/74611500-5b55bb00-50b1-11ea-8a96-205adb9249a4.png)
By using this line of code in the strings.xml, maintenance for fee changes are more easily accessible than going 600+ lines of code into the SendActivity.java. By adding a pop toast fee message, transparency is increased and a negative user experience can be avoided. Also, the message is set to pop for a short length, mitigating the redundancy an experienced user may feel. Here is an example:
![image](https://user-images.githubusercontent.com/38931215/74612187-eb96fe80-50b7-11ea-852d-09361ea95604.png)https://code.samourai.io/wallet/samourai-wallet-android/-/issues/351F-Droid availability2020-02-11T15:53:34ZT Dev. DF-Droid availability*Created by: xMate420x*
Hello. Is there an ETA on when the app will be available from the F-Droid store? I'm tired of compiling from source.*Created by: xMate420x*
Hello. Is there an ETA on when the app will be available from the F-Droid store? I'm tired of compiling from source.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/388Request: Verify Dojo connection from within wallet2020-02-07T22:35:53ZCrazyk031crazyk@samourai.ioRequest: Verify Dojo connection from within walletIt would be nice if you could ping/verify you are connected to your personal Dojo from within the wallet. Allowing you to verify on the go if your Dojo is up and running and you are successfully connecting.It would be nice if you could ping/verify you are connected to your personal Dojo from within the wallet. Allowing you to verify on the go if your Dojo is up and running and you are successfully connecting.https://code.samourai.io/wallet/samourai-wallet-android/-/issues/386Stub address size smaller than UTXO size when calculating entropy causing Arr...2020-01-31T12:17:16ZT Dev. DStub address size smaller than UTXO size when calculating entropy causing ArrayIndexOutOfBoundsException*Created by: MitchellCash*
I kept having issues when calculating entropy of a transaction and from what I could debug the issue seems to relate to having more UTXO than `stubAddress` values when building a transaction.
From my debugg...*Created by: MitchellCash*
I kept having issues when calculating entropy of a transaction and from what I could debug the issue seems to relate to having more UTXO than `stubAddress` values when building a transaction.
From my debugging I determined I have a UTXO set size of 42, however, on [SendActivity.java#L2222](https://github.com/Samourai-Wallet/samourai-wallet-android/blob/develop/app/src/main/java/com/samourai/wallet/send/SendActivity.java#L2222) when it iterates through the UTXO set and inserts both the UTXO value and the `stubAddress` value into the HashMap it gets an `ArrayIndexOutOfBoundsException` because the UTXO set of 42 exceeds the `stubAddress` size of [21](https://github.com/Samourai-Wallet/samourai-wallet-android/blob/develop/app/src/main/java/com/samourai/wallet/send/SendActivity.java#L174).https://code.samourai.io/wallet/samourai-wallet-android/-/issues/385Feature Request: Language selection option2020-01-24T21:24:03ZT Dev. DFeature Request: Language selection option*Created by: Relaxo143*
Let the user choose their language instead of using only the system one. Consider adding this to the next release as many non-english users would appreciate it.*Created by: Relaxo143*
Let the user choose their language instead of using only the system one. Consider adding this to the next release as many non-english users would appreciate it.