Sentinel-iOS issueshttps://code.samourai.io/wallet/Sentinel-iOS/-/issues2020-06-05T11:17:37Zhttps://code.samourai.io/wallet/Sentinel-iOS/-/issues/9Wrong background color in TableView headers2020-06-05T11:17:37ZGigiWrong background color in TableView headersCorrect colors are shown for iOS 11, but higher iOS versions will produce the wrong background color for the `TableView` headers. See the screenshot of the transaction list below:
![Simulator_Screen_Shot_-_iPhone_11_-_2020-04-17_at_10.3...Correct colors are shown for iOS 11, but higher iOS versions will produce the wrong background color for the `TableView` headers. See the screenshot of the transaction list below:
![Simulator_Screen_Shot_-_iPhone_11_-_2020-04-17_at_10.30.36](/uploads/09898af884d96ddc9ef451ae17793486/Simulator_Screen_Shot_-_iPhone_11_-_2020-04-17_at_10.30.36.png)https://code.samourai.io/wallet/Sentinel-iOS/-/issues/10Toggle for "Set PIN code" stays toggled in settings after PIN is deleted2020-06-05T11:20:18ZGigiToggle for "Set PIN code" stays toggled in settings after PIN is deletedTo reproduce:
1. Set PIN in settings
2. Delete PIN
3. Open settings view again
4. Observe "active" PIN toggleTo reproduce:
1. Set PIN in settings
2. Delete PIN
3. Open settings view again
4. Observe "active" PIN togglehttps://code.samourai.io/wallet/Sentinel-iOS/-/issues/11“Confirmed” in Transaction View should be green not yellow2020-06-05T11:26:35ZGigi“Confirmed” in Transaction View should be green not yellowThis might be intended, but it looked weird to me.
![Simulator_Screen_Shot_-_iPhone_11_-_2020-06-05_at_13.24.43](/uploads/e70590d636482c8f3f0faa3b297aeeff/Simulator_Screen_Shot_-_iPhone_11_-_2020-06-05_at_13.24.43.png)This might be intended, but it looked weird to me.
![Simulator_Screen_Shot_-_iPhone_11_-_2020-06-05_at_13.24.43](/uploads/e70590d636482c8f3f0faa3b297aeeff/Simulator_Screen_Shot_-_iPhone_11_-_2020-06-05_at_13.24.43.png)https://code.samourai.io/wallet/Sentinel-iOS/-/issues/12Crash when trying to rename a watched address2020-06-05T11:28:57ZGigiCrash when trying to rename a watched addressSteps to reproduce:
1. Add an address
2. Try to rename it
3. Crash: nil unwrap [line 53 in `NewWalletViewController.swift`]Steps to reproduce:
1. Add an address
2. Try to rename it
3. Crash: nil unwrap [line 53 in `NewWalletViewController.swift`]https://code.samourai.io/wallet/Sentinel-iOS/-/issues/13Push button in Push Transaction view shouldn’t be active if text field is empty2020-06-05T11:32:11ZGigiPush button in Push Transaction view shouldn’t be active if text field is emptyThe "Push Transaction" view will allow you to push an empty transaction, which will of course fail, showing an error.
It would probably be better to disable the `Push` button if the transaction field is empty in the first place.
![Simu...The "Push Transaction" view will allow you to push an empty transaction, which will of course fail, showing an error.
It would probably be better to disable the `Push` button if the transaction field is empty in the first place.
![Simulator_Screen_Shot_-_iPhone_11_-_2020-06-05_at_13.30.40](/uploads/bae21c712c2c30670dbf5ac16b8e4f79/Simulator_Screen_Shot_-_iPhone_11_-_2020-06-05_at_13.30.40.png)https://code.samourai.io/wallet/Sentinel-iOS/-/issues/14Replace outdated UIDevice extension with DeviceKit2020-06-05T11:38:46ZGigiReplace outdated UIDevice extension with DeviceKitThe code used in `Extension/Util.swift` to detect what device is used, i.e. the `UIDevice` extension, is outdated and doesn't include any of the newer screen resolutions or devices.
[DeviceKit](https://github.com/devicekit/DeviceKit) is...The code used in `Extension/Util.swift` to detect what device is used, i.e. the `UIDevice` extension, is outdated and doesn't include any of the newer screen resolutions or devices.
[DeviceKit](https://github.com/devicekit/DeviceKit) is a dedicated pod which was created for that purpose and is actively maintained. I would suggest to remove the custom extension and use DeviceKit instead.https://code.samourai.io/wallet/Sentinel-iOS/-/issues/15Fix breaking constraints in views2020-06-05T11:42:48ZGigiFix breaking constraints in viewsSome views have breaking constraints, especially on smaller devices.
I would suggest to debug all views by setting a symbolic breakpoint for `UIViewAlertForUnsatisfiableConstraints` and/or scan the logs for `NSLayoutConstraint` entries ...Some views have breaking constraints, especially on smaller devices.
I would suggest to debug all views by setting a symbolic breakpoint for `UIViewAlertForUnsatisfiableConstraints` and/or scan the logs for `NSLayoutConstraint` entries as described [here](https://developer.apple.com/library/archive/documentation/UserExperience/Conceptual/AutolayoutPG/DebuggingTricksandTips.html).https://code.samourai.io/wallet/Sentinel-iOS/-/issues/16Missing i18n of strings in UI2020-06-05T11:46:56ZGigiMissing i18n of strings in UISome strings are not localized, e.g. the title of the "Push Transaction" view.Some strings are not localized, e.g. the title of the "Push Transaction" view.https://code.samourai.io/wallet/Sentinel-iOS/-/issues/17Fix typos in app and code base2020-06-05T11:49:29ZGigiFix typos in app and code baseWhile digging through the code, I've found some typos in the code base as well as in the UI.
UI:
* pincode -> PIN code
Code:
* lenght -> length
* showReciving -> showReceiving
* unvalidAddres -> invalidAddressWhile digging through the code, I've found some typos in the code base as well as in the UI.
UI:
* pincode -> PIN code
Code:
* lenght -> length
* showReciving -> showReceiving
* unvalidAddres -> invalidAddresshttps://code.samourai.io/wallet/Sentinel-iOS/-/issues/7Asks for pin before setting one2019-03-12T10:42:49ZT Dev. DAsks for pin before setting one*Created by: Fonta1n3*
After install and import of xpub the app asks for pin even though one was never set. Closing the app reopening and setting the pin fixes the issue.*Created by: Fonta1n3*
After install and import of xpub the app asks for pin even though one was never set. Closing the app reopening and setting the pin fixes the issue.https://code.samourai.io/wallet/Sentinel-iOS/-/issues/8Import BIP44 XPUB does not show history or correct address2019-03-12T10:51:27ZT Dev. DImport BIP44 XPUB does not show history or correct address*Created by: Fonta1n3*
> Importing a BIP44 xpub with a transaction history does not show any history or the correct address.*Created by: Fonta1n3*
> Importing a BIP44 xpub with a transaction history does not show any history or the correct address.https://code.samourai.io/wallet/Sentinel-iOS/-/issues/5when release2019-02-12T10:40:33ZT Dev. Dwhen release*Created by: vesparny*
Hi, is this project going to be shipped anytime soon?*Created by: vesparny*
Hi, is this project going to be shipped anytime soon?